diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2019-03-27 16:15:20 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-27 14:27:30 -0700 |
| commit | 180a8c3d5dad5862b2f19727b363069bfecb26d8 (patch) | |
| tree | 3ad219a1a2b24c07d21e3abf1d0ed28693871b45 /drivers/net/phy/mdio-bcm-unimac.c | |
| parent | tcp: fix zerocopy and notsent_lowat issues (diff) | |
| download | linux-dev-180a8c3d5dad5862b2f19727b363069bfecb26d8.tar.xz linux-dev-180a8c3d5dad5862b2f19727b363069bfecb26d8.zip | |
net: phy: mdio-bcm-unimac: remove redundant !timeout check
The check for zero timeout is always true at the end of the proceeding
while loop; the only other exit path in the loop is if the unimac MDIO
is not busy. Remove the redundant zero timeout check and always
return -ETIMEDOUT on this timeout return path.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/phy/mdio-bcm-unimac.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/phy/mdio-bcm-unimac.c b/drivers/net/phy/mdio-bcm-unimac.c index 3a592629dc7e..4a28fb29adaa 100644 --- a/drivers/net/phy/mdio-bcm-unimac.c +++ b/drivers/net/phy/mdio-bcm-unimac.c @@ -92,10 +92,7 @@ static int unimac_mdio_poll(void *wait_func_data) usleep_range(1000, 2000); } while (--timeout); - if (!timeout) - return -ETIMEDOUT; - - return 0; + return -ETIMEDOUT; } static int unimac_mdio_read(struct mii_bus *bus, int phy_id, int reg) |