diff options
| author |   Jian Shen <shenjian15@huawei.com> | 2019-08-28 09:34:47 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-28 16:16:27 -0700 |
| commit | 95fb8bb3181bbe1ee87c95e91dff94f74f148c33 (patch) | |
| tree | c57aaf5b4a5d708030b5631c838663a1a7641fcc /drivers/net/phy/phy.c | |
| parent | Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue (diff) | |
| download | linux-dev-95fb8bb3181bbe1ee87c95e91dff94f74f148c33.tar.xz linux-dev-95fb8bb3181bbe1ee87c95e91dff94f74f148c33.zip | |
net: phy: force phy suspend when calling phy_stop
Some ethernet drivers may call phy_start() and phy_stop() from
ndo_open() and ndo_close() respectively.
When network cable is unconnected, and operate like below:
step 1: ifconfig ethX up -> ndo_open -> phy_start ->start
autoneg, and phy is no link.
step 2: ifconfig ethX down -> ndo_close -> phy_stop -> just stop
phy state machine.
This patch forces phy suspend even phydev->link is off.
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy.c')
| -rw-r--r-- | drivers/net/phy/phy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index f3adea9ef400..0acd5b49f450 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -911,8 +911,8 @@ void phy_state_machine(struct work_struct *work) if (phydev->link) { phydev->link = 0; phy_link_down(phydev, true); - do_suspend = true; } + do_suspend = true; break; } |