diff options
| author |   Russell King <rmk+kernel@armlinux.org.uk> | 2019-12-11 10:55:59 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-12-11 11:53:41 -0800 |
| commit | a4516c7053b96fed98a0439a9226983b5275474b (patch) | |
| tree | ac7628792fbd69eb7b5645f7fc9bf5c239ecd05b /drivers/net/phy/phylink.c | |
| parent | net: sfp: remove incomplete 100BASE-FX and 100BASE-LX support (diff) | |
| download | linux-dev-a4516c7053b96fed98a0439a9226983b5275474b.tar.xz linux-dev-a4516c7053b96fed98a0439a9226983b5275474b.zip | |
net: sfp: derive interface mode from ethtool link modes
We don't need the EEPROM ID to derive the phy interface mode as we can
derive it merely from the ethtool link modes. Remove the EEPROM ID
argument to sfp_select_interface().
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phylink.c')
| -rw-r--r-- | drivers/net/phy/phylink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 9a616d6bc4eb..b3e4d9bf8113 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -1714,7 +1714,7 @@ static int phylink_sfp_module_insert(void *upstream, linkmode_copy(support1, support); - iface = sfp_select_interface(pl->sfp_bus, id, config.advertising); + iface = sfp_select_interface(pl->sfp_bus, config.advertising); if (iface == PHY_INTERFACE_MODE_NA) { phylink_err(pl, "selection of interface failed, advertisement %*pb\n", |