diff options
| author |   Baruch Siach <baruch@tkos.co.il> | 2018-11-29 12:40:11 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-11-29 10:47:44 -0800 |
| commit | d7f7e0018b96fd1a30a968faa9464eb57372c1ec (patch) | |
| tree | 76879dff478db85115db45f312ea09560b2a6861 /drivers/net/phy/sfp-bus.c | |
| parent | Merge branch 'ave-fixes' (diff) | |
| download | linux-dev-d7f7e0018b96fd1a30a968faa9464eb57372c1ec.tar.xz linux-dev-d7f7e0018b96fd1a30a968faa9464eb57372c1ec.zip | |
net: phy: sfp: correct store of detected link modes
The link modes that sfp_parse_support() detects are stored in the
'modes' bitmap. There is no reason to make an exception for 1000Base-PX
or 1000Base-BX10.
Fixes: 03145864bd0f ("sfp: support 1G BiDi (eg, FiberStore SFP-GE-BX) modules")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/phy/sfp-bus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c index 83060fb349f4..ad9db652874d 100644 --- a/drivers/net/phy/sfp-bus.c +++ b/drivers/net/phy/sfp-bus.c @@ -162,7 +162,7 @@ void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id, /* 1000Base-PX or 1000Base-BX10 */ if ((id->base.e_base_px || id->base.e_base_bx10) && br_min <= 1300 && br_max >= 1200) - phylink_set(support, 1000baseX_Full); + phylink_set(modes, 1000baseX_Full); /* For active or passive cables, select the link modes * based on the bit rates and the cable compliance bytes. |