diff options
| author |   Russell King <rmk+kernel@armlinux.org.uk> | 2019-12-11 10:56:14 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-12-11 11:53:41 -0800 |
| commit | 4882057ad434e8a6434fce20dc7b7315d40a9d4a (patch) | |
| tree | 69b76d7e3deecfdbe35d0b15ded29d312086036c /drivers/net/phy/sfp.c | |
| parent | net: sfp: add module start/stop upstream notifications (diff) | |
| download | linux-dev-4882057ad434e8a6434fce20dc7b7315d40a9d4a.tar.xz linux-dev-4882057ad434e8a6434fce20dc7b7315d40a9d4a.zip | |
net: sfp: move phy_start()/phy_stop() to phylink
Move phy_start() and phy_stop() into the module_start and module_stop
notifications in phylink, rather than having them in the SFP code.
This gives phylink responsibility for controlling the PHY, rather
than having SFP start and stop the PHY state machine.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/sfp.c')
| -rw-r--r-- | drivers/net/phy/sfp.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 23f30dac0f17..d7d2c797c89c 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1396,7 +1396,6 @@ static void sfp_sm_mod_next(struct sfp *sfp, unsigned int state, static void sfp_sm_phy_detach(struct sfp *sfp) { - phy_stop(sfp->mod_phy); sfp_remove_phy(sfp->sfp_bus); phy_device_remove(sfp->mod_phy); phy_device_free(sfp->mod_phy); @@ -1427,7 +1426,6 @@ static void sfp_sm_probe_phy(struct sfp *sfp) } sfp->mod_phy = phy; - phy_start(phy); } static void sfp_sm_link_up(struct sfp *sfp) |