diff options
| author |   dingtianhong <dingtianhong@huawei.com> | 2013-12-26 19:40:35 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-12-26 13:31:33 -0500 |
| commit | 7ed8ca5b1e3311e569eabe5e847841830a3eced0 (patch) | |
| tree | db55bd98c72662b1eaadd39e559ca08fb84f48be /drivers/net/ppp/pppoe.c | |
| parent | hamradio: slight optimization of addr compare (diff) | |
| download | linux-dev-7ed8ca5b1e3311e569eabe5e847841830a3eced0.tar.xz linux-dev-7ed8ca5b1e3311e569eabe5e847841830a3eced0.zip | |
ppp: slight optimization of addr compare
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Michal Ostrowski <mostrows@earthlink.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ppp/pppoe.c')
| -rw-r--r-- | drivers/net/ppp/pppoe.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index 82ee6ed954cb..2ea7efd11857 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c @@ -131,12 +131,12 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net) static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b) { - return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN); + return a->sid == b->sid && ether_addr_equal(a->remote, b->remote); } static inline int cmp_addr(struct pppoe_addr *a, __be16 sid, char *addr) { - return a->sid == sid && !memcmp(a->remote, addr, ETH_ALEN); + return a->sid == sid && ether_addr_equal(a->remote, addr); } #if 8 % PPPOE_HASH_BITS |