diff options
| author |   Francois Romieu <romieu@fr.zoreil.com> | 2006-11-29 22:21:33 +0100 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@woody.osdl.org> | 2006-11-29 13:45:07 -0800 |
| commit | 315917d23fdd20a0f4ff99b9228de5840d9d276c (patch) | |
| tree | d1ddfc02bcfe5c7f57ed604c7d928d6e1bd74d11 /drivers/net/r8169.c | |
| parent | Merge branch 'for-linus' of master.kernel.org:/home/rmk/linux-2.6-arm (diff) | |
| download | linux-dev-315917d23fdd20a0f4ff99b9228de5840d9d276c.tar.xz linux-dev-315917d23fdd20a0f4ff99b9228de5840d9d276c.zip | |
[PATCH] r8169: Fix iteration variable sign
This changes the type of variable "i" in rtl8169_init_one()
from "unsigned int" to "int". "i" is checked for < 0 later,
which can never happen for "unsigned". This results in broken
error handling.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/r8169.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 27f90b2139c0..b977ed85ff39 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1473,8 +1473,8 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) struct rtl8169_private *tp; struct net_device *dev; void __iomem *ioaddr; - unsigned int i, pm_cap; - int rc; + unsigned int pm_cap; + int i, rc; if (netif_msg_drv(&debug)) { printk(KERN_INFO "%s Gigabit Ethernet driver %s loaded\n", |