aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/usb/asix_devices.c
diff options
context:
space:
mode:
authorDean Jenkins <Dean_Jenkins@mentor.com>2017-08-07 09:50:16 +0100
committerDavid S. Miller <davem@davemloft.net>2017-08-07 10:10:19 -0700
commitd0c8f338ab41438bdf8472cb4209d4ab54d439d5 (patch)
treeafd69174d5166583e8f7a2c6d36b6c4247a7a077 /drivers/net/usb/asix_devices.c
parentasix: Ensure asix_rx_fixup_info members are all reset (diff)
downloadlinux-dev-d0c8f338ab41438bdf8472cb4209d4ab54d439d5.tar.xz
linux-dev-d0c8f338ab41438bdf8472cb4209d4ab54d439d5.zip
asix: Fix small memory leak in ax88772_unbind()
When Ethernet frames span mulitple URBs, the netdev buffer memory pointed to by the asix_rx_fixup_info structure remains allocated during the time gap between the 2 executions of asix_rx_fixup_internal(). This means that if ax88772_unbind() is called within this time gap to free the memory of the parent private data structure then a memory leak of the part filled netdev buffer memory will occur. Therefore, create a new function asix_rx_fixup_common_free() to free the memory of the netdev buffer and add a call to asix_rx_fixup_common_free() from inside ax88772_unbind(). Consequently when an unbind occurs part way through receiving an Ethernet frame, the netdev buffer memory that is holding part of the received Ethernet frame will now be freed. Signed-off-by: Dean Jenkins <Dean_Jenkins@mentor.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
-rw-r--r--drivers/net/usb/asix_devices.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index a3aa0a27dfe5..b2ff88e69a81 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -764,6 +764,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
{
+ asix_rx_fixup_common_free(dev->driver_priv);
kfree(dev->driver_priv);
}