diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2018-09-28 16:18:55 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-29 11:31:29 -0700 |
| commit | 9c734b2769a73eea2e9e9767c0e0bf839ff23679 (patch) | |
| tree | 002c47b599d640ac9d84abe47b199f8e6cc40f56 /drivers/net/usb/smsc75xx.c | |
| parent | r8152: Check for supported Wake-on-LAN Modes (diff) | |
| download | linux-dev-9c734b2769a73eea2e9e9767c0e0bf839ff23679.tar.xz linux-dev-9c734b2769a73eea2e9e9767c0e0bf839ff23679.zip | |
smsc75xx: Check for Wake-on-LAN modes
The driver does not check for Wake-on-LAN modes specified by an user,
but will conditionally set the device as wake-up enabled or not based on
that, which could be a very confusing user experience.
Fixes: 6c636503260d ("smsc75xx: add wol magic packet support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/usb/smsc75xx.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index 05553d252446..e5a4cbb366dc 100644 --- a/drivers/net/usb/smsc75xx.c +++ b/drivers/net/usb/smsc75xx.c @@ -731,6 +731,9 @@ static int smsc75xx_ethtool_set_wol(struct net_device *net, struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]); int ret; + if (wolinfo->wolopts & ~SUPPORTED_WAKE) + return -EINVAL; + pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE; ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts); |