diff options
| author |   Ping-Ke Shih <pkshih@realtek.com> | 2022-08-24 14:33:11 +0800 |
|---|---|---|
| committer |   Kalle Valo <kvalo@kernel.org> | 2022-09-02 11:37:03 +0300 |
| commit | b7e715d3dcd2e9fa3a689ba0dd7ab85f8aaf6e9a (patch) | |
| tree | 343a022d48f0b1781ebc73cab26fdfcbde741587 /drivers/net/wireless | |
| parent | wifi: rtw89: enlarge the CFO tracking boundary (diff) | |
| download | linux-dev-b7e715d3dcd2e9fa3a689ba0dd7ab85f8aaf6e9a.tar.xz linux-dev-b7e715d3dcd2e9fa3a689ba0dd7ab85f8aaf6e9a.zip | |
wifi: rtw89: pci: fix interrupt stuck after leaving low power mode
We turn off interrupt in ISR, and re-enable interrupt in threadfn or
napi_poll according to the mode it stays. If we are turning off interrupt,
rtwpci->running flag is unset and interrupt handler stop processing even
if it was called, so disallow to re-enable interrupt in this situation.
Or, wifi chip doesn't trigger interrupt events anymore because interrupt
status (ISR) isn't clear by interrupt handler anymore.
Fixes: c83dcd0508e2 ("rtw89: pci: add a separate interrupt handler for low power mode")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220824063312.15784-1-pkshih@realtek.com
Diffstat (limited to 'drivers/net/wireless')
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/pci.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c index aad56a35c86c..65468c5e1612 100644 --- a/drivers/net/wireless/realtek/rtw89/pci.c +++ b/drivers/net/wireless/realtek/rtw89/pci.c @@ -760,7 +760,8 @@ static irqreturn_t rtw89_pci_interrupt_threadfn(int irq, void *dev) enable_intr: spin_lock_irqsave(&rtwpci->irq_lock, flags); - rtw89_chip_enable_intr(rtwdev, rtwpci); + if (likely(rtwpci->running)) + rtw89_chip_enable_intr(rtwdev, rtwpci); spin_unlock_irqrestore(&rtwpci->irq_lock, flags); return IRQ_HANDLED; } |