diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2016-11-10 09:55:42 +0100 |
|---|---|---|
| committer |   Juergen Gross <jgross@suse.com> | 2016-11-10 09:55:42 +0100 |
| commit | 0f06ac3b6616b9793b3fb5c398d94044a0423492 (patch) | |
| tree | 0e96c332df5a2214c75064a442f6a188a583a859 /drivers/net/xen-netback | |
| parent | xen: make use of xenbus_read_unsigned() in xenbus (diff) | |
| download | linux-dev-0f06ac3b6616b9793b3fb5c398d94044a0423492.tar.xz linux-dev-0f06ac3b6616b9793b3fb5c398d94044a0423492.zip | |
xen-netback: fix error handling output
The connect function prints an unintialized error code after an
earlier initialization was removed:
drivers/net/xen-netback/xenbus.c: In function 'connect':
drivers/net/xen-netback/xenbus.c:938:3: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This prints it as -EINVAL instead, which seems to be the most
appropriate error code. Before the patch that caused the warning,
this would print a positive number returned by vsscanf() instead,
which is also wrong. We probably don't need a backport though,
as fixing the warning here should be sufficient.
Fixes: f95842e7a9f2 ("xen: make use of xenbus_read_unsigned() in xen-netback")
Fixes: 8d3d53b3e433 ("xen-netback: Add support for multiple queues")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Diffstat (limited to 'drivers/net/xen-netback')
| -rw-r--r-- | drivers/net/xen-netback/xenbus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 7356e00fac54..bfed79877b8a 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -935,7 +935,7 @@ static void connect(struct backend_info *be) "multi-queue-num-queues", 1); if (requested_num_queues > xenvif_max_queues) { /* buggy or malicious guest */ - xenbus_dev_fatal(dev, err, + xenbus_dev_fatal(dev, -EINVAL, "guest requested %u queues, exceeding the maximum of %u.", requested_num_queues, xenvif_max_queues); return; |