diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2014-08-08 12:07:53 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-08-08 10:28:08 -0700 |
| commit | 6a3e6aa10bf516c5c507292489e4d1fddeb2901b (patch) | |
| tree | fe8ce33fc607f72b0029d325633074e7ccb1681a /drivers/net | |
| parent | net: axienet: delete unneeded test before of_node_put (diff) | |
| download | linux-dev-6a3e6aa10bf516c5c507292489e4d1fddeb2901b.tar.xz linux-dev-6a3e6aa10bf516c5c507292489e4d1fddeb2901b.zip | |
ll_temac: delete unneeded test before of_node_put
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/xilinx/ll_temac_main.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 8a6e5c2d6f95..36f4459520c3 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1148,8 +1148,7 @@ static int temac_of_remove(struct platform_device *op) temac_mdio_teardown(lp); unregister_netdev(ndev); sysfs_remove_group(&lp->dev->kobj, &temac_attr_group); - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); lp->phy_node = NULL; iounmap(lp->regs); if (lp->sdma_regs) |