diff options
| author |   Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2021-12-24 10:13:24 +0800 |
|---|---|---|
| committer |   Marc Kleine-Budde <mkl@pengutronix.de> | 2022-01-09 13:32:28 +0100 |
| commit | c6564c13dae25cd7f8e1de5127b4da4500ee5844 (patch) | |
| tree | ab76e17189fe923fc531c10488ddd4759952b419 /drivers/net | |
| parent | can: softing: softing_startstop(): fix set but not used variable warning (diff) | |
| download | linux-dev-c6564c13dae25cd7f8e1de5127b4da4500ee5844.tar.xz linux-dev-c6564c13dae25cd7f8e1de5127b4da4500ee5844.zip | |
can: xilinx_can: xcan_probe(): check for error irq
For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq()
effectively convert that into -EINVAL, even at probe time rather than
later on. So it might be better to check just now.
Fixes: b1201e44f50b ("can: xilinx CAN controller support")
Link: https://lore.kernel.org/all/20211224021324.1447494-1-jiasheng@iscas.ac.cn
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/can/xilinx_can.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index e2b15d29d15e..af4a2adc8598 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1761,7 +1761,12 @@ static int xcan_probe(struct platform_device *pdev) spin_lock_init(&priv->tx_lock); /* Get IRQ for the device */ - ndev->irq = platform_get_irq(pdev, 0); + ret = platform_get_irq(pdev, 0); + if (ret < 0) + goto err_free; + + ndev->irq = ret; + ndev->flags |= IFF_ECHO; /* We support local echo */ platform_set_drvdata(pdev, ndev); |