diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-23 17:18:36 +0300 |
|---|---|---|
| committer |   Sagi Grimberg <sagi@grimberg.me> | 2019-09-25 12:53:14 -0700 |
| commit | bc4f6e06a90ea016855fc67212b4d500145f0b8a (patch) | |
| tree | 6f4882e583a7f1bb652fa38a4cd7da9d25afa541 /drivers/nvme/host/core.c | |
| parent | nvme-pci: Save PCI state before putting drive into deepest state (diff) | |
| download | linux-dev-bc4f6e06a90ea016855fc67212b4d500145f0b8a.tar.xz linux-dev-bc4f6e06a90ea016855fc67212b4d500145f0b8a.zip | |
nvme: fix an error code in nvme_init_subsystem()
"ret" should be a negative error code here, but it's either success or
possibly uninitialized.
Fixes: 32fd90c40768 ("nvme: change locking for the per-subsystem controller list")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Diffstat (limited to '')
| -rw-r--r-- | drivers/nvme/host/core.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 0c385b1994fe..d3c9df62a9d5 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2543,8 +2543,9 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) list_add_tail(&subsys->entry, &nvme_subsystems); } - if (sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj, - dev_name(ctrl->device))) { + ret = sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj, + dev_name(ctrl->device)); + if (ret) { dev_err(ctrl->device, "failed to create sysfs link from subsystem.\n"); goto out_put_subsystem; |