diff options
| author |   Yi Zhang <yi.zhang@redhat.com> | 2020-02-14 18:48:02 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2020-02-14 10:12:04 -0700 |
| commit | f25372ffc3f6c2684b57fb718219137e6ee2b64c (patch) | |
| tree | 16bbfbd519f72007bd5dbfcff8db8d4692044a4e /drivers/nvme/host/core.c | |
| parent | nvme/pci: move cqe check after device shutdown (diff) | |
| download | linux-dev-f25372ffc3f6c2684b57fb718219137e6ee2b64c.tar.xz linux-dev-f25372ffc3f6c2684b57fb718219137e6ee2b64c.zip | |
nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info
nvme fw-activate operation will get bellow warning log,
fix it by update the parameter order
[ 113.231513] nvme nvme0: Get FW SLOT INFO log error
Fixes: 0e98719b0e4b ("nvme: simplify the API for getting log pages")
Reported-by: Sujith Pandel <sujith_pandel@dell.com>
Reviewed-by: David Milburn <dmilburn@redhat.com>
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to '')
| -rw-r--r-- | drivers/nvme/host/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 7f05deada7f4..ada59df642d2 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3867,7 +3867,7 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl *ctrl) if (!log) return; - if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log, + if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log, sizeof(*log), 0)) dev_warn(ctrl->device, "Get FW SLOT INFO log error\n"); kfree(log); |