diff options
| author |   James Smart <james.smart@broadcom.com> | 2020-10-16 14:06:04 -0700 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2020-10-23 12:54:23 +0200 |
| commit | 514a6dc9ecfd2fe4e1deebcb7a63e3de23e6c38b (patch) | |
| tree | 315a03629876464a36c3ccf705f57ca251a69b30 /drivers/nvme/host/fc.c | |
| parent | nvme-fc: fix io timeout to abort I/O (diff) | |
| download | linux-dev-514a6dc9ecfd2fe4e1deebcb7a63e3de23e6c38b.tar.xz linux-dev-514a6dc9ecfd2fe4e1deebcb7a63e3de23e6c38b.zip | |
nvme-fc: fix error loop in create_hw_io_queues
The loop that backs out of hw io queue creation continues through index
0, which corresponds to the admin queue as well.
Fix the loop so it only proceeds through indexes 1..n which correspond to
I/O queues.
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to '')
| -rw-r--r-- | drivers/nvme/host/fc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 3e72b7d74df3..108130f140d0 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -2317,7 +2317,7 @@ nvme_fc_create_hw_io_queues(struct nvme_fc_ctrl *ctrl, u16 qsize) return 0; delete_queues: - for (; i >= 0; i--) + for (; i > 0; i--) __nvme_fc_delete_hw_queue(ctrl, &ctrl->queues[i], i); return ret; } @@ -2436,7 +2436,7 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg) return; dev_warn(ctrl->ctrl.device, - "NVME-FC{%d}: transport association error detected: %s\n", + "NVME-FC{%d}: transport association event: %s\n", ctrl->cnum, errmsg); dev_warn(ctrl->ctrl.device, "NVME-FC{%d}: resetting controller\n", ctrl->cnum); |