diff options
| author |   Keith Busch <keith.busch@intel.com> | 2018-06-06 08:13:06 -0600 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2018-06-08 12:51:11 -0600 |
| commit | ded45505dbfdcaf1e49ae0349e5dafb59c9efbe5 (patch) | |
| tree | 190b52254902749ccf70927a9432ab3668438a91 /drivers/nvme/host/pci.c | |
| parent | nvme-pci: remove unnecessary completion doorbell check (diff) | |
| download | linux-dev-ded45505dbfdcaf1e49ae0349e5dafb59c9efbe5.tar.xz linux-dev-ded45505dbfdcaf1e49ae0349e5dafb59c9efbe5.zip | |
nvme-pci: queue creation fixes
We've been ignoring NVMe error status on queue creations. Fortunately they
are uncommon, but we should handle these anyway. This patch adds checks
for the a positive error return value that indicates an NVMe status.
If we do see a negative return, the controller isn't usable, so this
patch returns immediately in since we can't unwind that failure.
Signed-off-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to '')
| -rw-r--r-- | drivers/nvme/host/pci.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 4963a407e728..7a42ccad3864 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1475,11 +1475,13 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid) */ vector = dev->num_vecs == 1 ? 0 : qid; result = adapter_alloc_cq(dev, qid, nvmeq, vector); - if (result < 0) - goto out; + if (result) + return result; result = adapter_alloc_sq(dev, qid, nvmeq); if (result < 0) + return result; + else if (result) goto release_cq; /* @@ -1501,7 +1503,6 @@ release_sq: adapter_delete_sq(dev, qid); release_cq: adapter_delete_cq(dev, qid); -out: return result; } |