diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2019-09-20 14:20:30 +0200 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2019-10-04 23:08:47 +0200 |
| commit | 5ff8aca906f3a7a7db79fad92f2a4401107ef50d (patch) | |
| tree | 7e9dea9404184281c94953c09e1225ac60544fa8 /drivers/pinctrl | |
| parent | pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core (diff) | |
| download | linux-dev-5ff8aca906f3a7a7db79fad92f2a4401107ef50d.tar.xz linux-dev-5ff8aca906f3a7a7db79fad92f2a4401107ef50d.zip | |
pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call
The call to pinctrl_count_index_with_args checks for a -EINVAL return
however this function calls pinctrl_get_list_and_count and this can
return -ENOENT. Rather than check for a specific error, fix this by
checking for any error return to catch the -ENOENT case.
Addresses-Coverity: ("Improper use of negative")
Fixes: 003910ebc83b ("pinctrl: Introduce TI IOdelay configuration driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190920122030.14340-1-colin.king@canonical.com
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c index e5e7f1f22813..b522ca010332 100644 --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c @@ -496,7 +496,7 @@ static int ti_iodelay_dt_node_to_map(struct pinctrl_dev *pctldev, return -EINVAL; rows = pinctrl_count_index_with_args(np, name); - if (rows == -EINVAL) + if (rows < 0) return rows; *map = devm_kzalloc(iod->dev, sizeof(**map), GFP_KERNEL); |