diff options
| author |   Julian Wiedmann <jwi@linux.ibm.com> | 2021-11-15 08:28:08 +0100 |
|---|---|---|
| committer |   Heiko Carstens <hca@linux.ibm.com> | 2021-12-06 14:42:25 +0100 |
| commit | 513251fe25d304d1ca628c581bd0cc0422de150a (patch) | |
| tree | 559e401288d20c6c043dd97760b77499bc1cab3e /drivers/s390/cio/qdio_setup.c | |
| parent | s390/qdio: clean up access to queue in qdio_handle_activate_check() (diff) | |
| download | linux-dev-513251fe25d304d1ca628c581bd0cc0422de150a.tar.xz linux-dev-513251fe25d304d1ca628c581bd0cc0422de150a.zip | |
s390/qdio: clarify handler logic for qdio_handle_activate_check()
qdio_handle_activate_check() tries to re-use one of the queue-specific
handlers to report that the ACTIVATE ccw has been terminated. But the
logic to select that handler is overly complex - in practice both
qdio drivers have at least one Input Queue, so we never take the other
paths.
Make things more obvious by removing this unused code, and clearly
spelling out that we re-use the Input Handler for generic error
reporting. This also paves the way for a world without queue-specific
error handlers.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/s390/cio/qdio_setup.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/s390/cio/qdio_setup.c b/drivers/s390/cio/qdio_setup.c index fd663922d7d5..714878e2acc4 100644 --- a/drivers/s390/cio/qdio_setup.c +++ b/drivers/s390/cio/qdio_setup.c @@ -362,6 +362,7 @@ void qdio_setup_irq(struct qdio_irq *irq_ptr, struct qdio_initialize *init_data) irq_ptr->debugfs_dev = NULL; irq_ptr->sch_token = irq_ptr->perf_stat_enabled = 0; irq_ptr->state = QDIO_IRQ_STATE_INACTIVE; + irq_ptr->error_handler = init_data->input_handler; irq_ptr->int_parm = init_data->int_parm; irq_ptr->nr_input_qs = init_data->no_input_qs; |