diff options
| author |   Eric Farman <farman@linux.ibm.com> | 2022-07-28 22:49:14 +0200 |
|---|---|---|
| committer |   Alex Williamson <alex.williamson@redhat.com> | 2022-08-01 13:36:47 -0600 |
| commit | 4eb919663d97e056dff8963fde22df3b0ad4d02b (patch) | |
| tree | a96c4b5dba6a0e8cec8af301041cac7854f6f535 /drivers/s390/cio/vfio_ccw_fsm.c | |
| parent | vfio/ccw: Remove FSM Close from remove handlers (diff) | |
| download | linux-dev-4eb919663d97e056dff8963fde22df3b0ad4d02b.tar.xz linux-dev-4eb919663d97e056dff8963fde22df3b0ad4d02b.zip | |
vfio/ccw: Check return code from subchannel quiesce
If a subchannel is busy when a close is performed, the subchannel
needs to be quiesced and left nice and tidy, so nothing unexpected
(like a solicited interrupt) shows up while in the closed state.
Unfortunately, the return code from this call isn't checked,
so any busy subchannel is treated as a failing one.
Fix that, so that the close on a busy subchannel happens normally.
Signed-off-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20220728204914.2420989-4-farman@linux.ibm.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/s390/cio/vfio_ccw_fsm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/cio/vfio_ccw_fsm.c b/drivers/s390/cio/vfio_ccw_fsm.c index 4b8b623df24f..a59c758869f8 100644 --- a/drivers/s390/cio/vfio_ccw_fsm.c +++ b/drivers/s390/cio/vfio_ccw_fsm.c @@ -407,7 +407,7 @@ static void fsm_close(struct vfio_ccw_private *private, ret = cio_disable_subchannel(sch); if (ret == -EBUSY) - vfio_ccw_sch_quiesce(sch); + ret = vfio_ccw_sch_quiesce(sch); if (ret) goto err_unlock; |