diff options
| author |   Ingo Tuchscherer <ingo.tuchscherer@linux.vnet.ibm.com> | 2016-07-25 14:52:28 +0200 |
|---|---|---|
| committer |   Martin Schwidefsky <schwidefsky@de.ibm.com> | 2016-07-31 05:27:58 -0400 |
| commit | d6d86c57d77d466df2096b134e5f54463d3f0fb8 (patch) | |
| tree | e228aa3826f9e587db7c2d5f88e0e6f36da78477 /drivers/s390/crypto/zcrypt_pcixcc.c | |
| parent | s390/cio: fix premature wakeup during chp configure (diff) | |
| download | linux-dev-d6d86c57d77d466df2096b134e5f54463d3f0fb8.tar.xz linux-dev-d6d86c57d77d466df2096b134e5f54463d3f0fb8.zip | |
s390/zcrypt: Fix zcrypt suspend/resume behavior
The device suspend call triggers all ap devices to fetch potentially
available response messages from the queues. Therefore the
corresponding zcrypt device, that is allocated asynchronously after
ap device probing, needs to be fully prepared. This race condition
could lead to uninitialized response buffers while trying to read
from the queues.
Introduce a new callback within the ap layer to get noticed when a
zcrypt device is fully prepared. Additional checks prevent reading
from devices that are not fully prepared.
Signed-off-by: Ingo Tuchscherer <ingo.tuchscherer@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/s390/crypto/zcrypt_pcixcc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/crypto/zcrypt_pcixcc.c b/drivers/s390/crypto/zcrypt_pcixcc.c index f41852768953..df8f0c4dacb7 100644 --- a/drivers/s390/crypto/zcrypt_pcixcc.c +++ b/drivers/s390/crypto/zcrypt_pcixcc.c @@ -327,7 +327,7 @@ static int zcrypt_pcixcc_probe(struct ap_device *ap_dev) else zdev->ops = zcrypt_msgtype_request(MSGTYPE06_NAME, MSGTYPE06_VARIANT_NORNG); - ap_dev->reply = &zdev->reply; + ap_device_init_reply(ap_dev, &zdev->reply); ap_dev->private = zdev; rc = zcrypt_device_register(zdev); if (rc) |