diff options
| author |   Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> | 2014-05-28 10:22:30 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-05-30 17:35:23 -0700 |
| commit | e95051ff5a0b76e672f6d30e8bb8f93cc11c8018 (patch) | |
| tree | efa374a49ad465442f6f926297cc4d98a3c266a8 /drivers/s390/net/qeth_core_main.c | |
| parent | af_iucv: correct cleanup if listen backlog is full (diff) | |
| download | linux-dev-e95051ff5a0b76e672f6d30e8bb8f93cc11c8018.tar.xz linux-dev-e95051ff5a0b76e672f6d30e8bb8f93cc11c8018.zip | |
qeth: Fix for possible null pointer dereference
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/s390/net/qeth_core_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 34993009a9e1..549e9fd5bfdc 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -1013,7 +1013,7 @@ static long __qeth_check_irb_error(struct ccw_device *cdev, card = CARD_FROM_CDEV(cdev); - if (!IS_ERR(irb)) + if (!card || !IS_ERR(irb)) return 0; switch (PTR_ERR(irb)) { @@ -1029,7 +1029,7 @@ static long __qeth_check_irb_error(struct ccw_device *cdev, QETH_CARD_TEXT(card, 2, "ckirberr"); QETH_CARD_TEXT_(card, 2, " rc%d", -ETIMEDOUT); if (intparm == QETH_RCD_PARM) { - if (card && (card->data.ccwdev == cdev)) { + if (card->data.ccwdev == cdev) { card->data.state = CH_STATE_DOWN; wake_up(&card->wait_q); } |