diff options
| author |   Julian Wiedmann <jwi@linux.ibm.com> | 2020-07-30 17:01:19 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-07-31 16:44:35 -0700 |
| commit | 7c94a88295008f66e9a0efc1c15d8511f73a0366 (patch) | |
| tree | d272633be577fc45d1ecd5622389867e6b2382da /drivers/s390/net/qeth_l2_main.c | |
| parent | s390/qeth: tolerate pre-filled RX buffer (diff) | |
| download | linux-dev-7c94a88295008f66e9a0efc1c15d8511f73a0366.tar.xz linux-dev-7c94a88295008f66e9a0efc1c15d8511f73a0366.zip | |
s390/qeth: integrate RX refill worker with NAPI
Running a RX refill outside of NAPI context is inherently racy, even
though the worker is only started for an entirely idle RX ring.
>From the moment that the worker has replenished parts of the RX ring,
the HW can use those RX buffers, raise an IRQ and cause our NAPI code to
run concurrently to the RX refill worker.
Instead let the worker schedule our NAPI instance, and refill the RX
ring from there. Keeping accurate count of how many buffers still need
to be refilled also removes some quirky arithmetic from the low-level
code.
Fixes: b333293058aa ("qeth: add support for af_iucv HiperSockets transport")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/s390/net/qeth_l2_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c index ef7a2db7a724..38e97bbde9ed 100644 --- a/drivers/s390/net/qeth_l2_main.c +++ b/drivers/s390/net/qeth_l2_main.c @@ -285,7 +285,6 @@ static void qeth_l2_stop_card(struct qeth_card *card) if (card->state == CARD_STATE_SOFTSETUP) { qeth_clear_ipacmd_list(card); qeth_drain_output_queues(card); - cancel_delayed_work_sync(&card->buffer_reclaim_work); card->state = CARD_STATE_DOWN; } |