diff options
| author |   Julian Wiedmann <jwi@linux.ibm.com> | 2019-10-31 13:42:19 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-31 12:32:59 -0700 |
| commit | 04fa55fe07d15587b00ef1269fcbf793a2e45739 (patch) | |
| tree | ecdcf711d4e5b0e0a8c92264515c7cd56c42164b /drivers/s390/net | |
| parent | s390/qeth: consolidate some duplicated HW cmd code (diff) | |
| download | linux-dev-04fa55fe07d15587b00ef1269fcbf793a2e45739.tar.xz linux-dev-04fa55fe07d15587b00ef1269fcbf793a2e45739.zip | |
s390/qeth: don't set card state in qeth_qdio_clear_card()
Any change to the card state should only be driven by
qeth_l?_set_online() and qeth_l?_stop_card().
qeth_qdio_clear_card() currently also gets called from
(a) qeth_core_shutdown(), where we haven't walked through the whole
teardown sequence. So changing the state to DOWN is not accurate.
(b) qeth_core_hardsetup_card(), which is only called while the card is
still in DOWN state. No change in behaviour here.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net')
| -rw-r--r-- | drivers/s390/net/qeth_core_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index d51dcb3c5a01..9e8bd8e08146 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -1513,7 +1513,6 @@ int qeth_qdio_clear_card(struct qeth_card *card, int use_halt) rc = qeth_clear_halt_card(card, use_halt); if (rc) QETH_CARD_TEXT_(card, 3, "2err%d", rc); - card->state = CARD_STATE_DOWN; return rc; } EXPORT_SYMBOL_GPL(qeth_qdio_clear_card); |