diff options
| author |   James Smart <jsmart2021@gmail.com> | 2019-03-04 15:27:51 -0800 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2019-03-06 19:26:45 -0500 |
| commit | 1ffdd2c0440dfda533ca9477a89550c9f48f4b35 (patch) | |
| tree | 6bfccb50555c7ba1aadf9aed5dcd5d20d8a13a17 /drivers/scsi/lpfc/lpfc_init.c | |
| parent | scsi: lpfc: Correct __lpfc_sli_issue_iocb_s4 lockdep check (diff) | |
| download | linux-dev-1ffdd2c0440dfda533ca9477a89550c9f48f4b35.tar.xz linux-dev-1ffdd2c0440dfda533ca9477a89550c9f48f4b35.zip | |
scsi: lpfc: resolve static checker warning in lpfc_sli4_hba_unset
The patch that replaced io channels for hdw_queues now reports the
following static checker warning:
drivers/scsi/lpfc/lpfc_init.c:11136 lpfc_sli4_hba_unset()
error: we previously assumed 'phba->pport' could be null (see line 11074)
Resolve by adding a pport NULL check.
[mkp: tag tweak]
Fixes: cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu"_
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/scsi/lpfc/lpfc_init.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 3eb04c3be300..cd09b2120abd 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -11132,7 +11132,8 @@ lpfc_sli4_hba_unset(struct lpfc_hba *phba) lpfc_sli4_ras_dma_free(phba); /* Stop the SLI4 device port */ - phba->pport->work_port_events = 0; + if (phba->pport) + phba->pport->work_port_events = 0; } /** |