diff options
| author |   Mark Knibbs <markk@clara.co.uk> | 2014-10-09 12:39:48 +0100 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2014-11-12 11:15:53 +0100 |
| commit | 605c6dbef7556604b20b9831ea790dfe988416d8 (patch) | |
| tree | 65a47a5d21f530f0836e77ce0ec880ac009b1583 /drivers/scsi/scsi_scan.c | |
| parent | scsi: fix trivial typos in scsi_scan.c comment (diff) | |
| download | linux-dev-605c6dbef7556604b20b9831ea790dfe988416d8.tar.xz linux-dev-605c6dbef7556604b20b9831ea790dfe988416d8.zip | |
scsi: fix off-by-one LUN check in scsi_scan_host_selected()
The Scsi_Host structure max_lun field is the maximum allowed LUN plus 1. So
a LUN value is invalid if >= max_lun.
Signed-off-by: Mark Knibbs <markk@clara.co.uk>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/scsi_scan.c')
| -rw-r--r-- | drivers/scsi/scsi_scan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 619e68d015aa..b1aa1646012a 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1727,7 +1727,7 @@ int scsi_scan_host_selected(struct Scsi_Host *shost, unsigned int channel, if (((channel != SCAN_WILD_CARD) && (channel > shost->max_channel)) || ((id != SCAN_WILD_CARD) && (id >= shost->max_id)) || - ((lun != SCAN_WILD_CARD) && (lun > shost->max_lun))) + ((lun != SCAN_WILD_CARD) && (lun >= shost->max_lun))) return -EINVAL; mutex_lock(&shost->scan_mutex); |