diff options
| author |   Christoph Hellwig <hch@lst.de> | 2006-01-04 13:45:20 +0100 |
|---|---|---|
| committer |   James Bottomley <jejb@mulgrave.(none)> | 2006-01-14 10:54:44 -0600 |
| commit | d4054239929479907f20b9d68c905589125ad343 (patch) | |
| tree | 09b02453ac3adde7df61ad32f684996f0329874e /drivers/scsi/scsi_transport_sas.c | |
| parent | [SCSI] Pass proper device from BusLogic to SCSI layer (diff) | |
| download | linux-dev-d4054239929479907f20b9d68c905589125ad343.tar.xz linux-dev-d4054239929479907f20b9d68c905589125ad343.zip | |
[SCSI] sas: fix removal of devices behind expanders
We need to iterate over all children when removing and expander, else
stale objects will be around after host removal. This fixes the oops
Eric Moore saw when removing and reloading mptsas.
Also don't try the scsi_remove_target call unless operating on an end
device. The current unconditional call is harmless but confusing.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/scsi_transport_sas.c')
| -rw-r--r-- | drivers/scsi/scsi_transport_sas.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 357b52f5f996..e950435a11d8 100644 --- a/drivers/scsi/scsi_transport_sas.c +++ b/drivers/scsi/scsi_transport_sas.c @@ -687,7 +687,17 @@ sas_rphy_delete(struct sas_rphy *rphy) struct Scsi_Host *shost = dev_to_shost(parent->dev.parent); struct sas_host_attrs *sas_host = to_sas_host_attrs(shost); - scsi_remove_target(dev); + switch (rphy->identify.device_type) { + case SAS_END_DEVICE: + scsi_remove_target(dev); + break; + case SAS_EDGE_EXPANDER_DEVICE: + case SAS_FANOUT_EXPANDER_DEVICE: + device_for_each_child(dev, NULL, do_sas_phy_delete); + break; + default: + break; + } transport_remove_device(dev); device_del(dev); |