diff options
| author |   Akinobu Mita <akinobu.mita@gmail.com> | 2014-11-18 23:02:46 +0900 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2014-11-26 11:32:32 +0100 |
| commit | 3e660fbef96f53d01ba022b1b75b72759a02983e (patch) | |
| tree | e945d6e509e0b820a6150bc7f91398d519969fb0 /drivers/scsi/ufs/ufshcd.c | |
| parent | ufs: ensure clk gating work is finished before module unloading (diff) | |
| download | linux-dev-3e660fbef96f53d01ba022b1b75b72759a02983e.tar.xz linux-dev-3e660fbef96f53d01ba022b1b75b72759a02983e.zip | |
ufs: fix NULL dereference when no regulators are defined
If no voltage supply regulators are defined for the UFS devices (assumed
they are always-on), ufshcd_config_vreg_load() can be called on
suspend/resume paths with vreg == NULL as hba->vreg_info.vcc* equal to
NULL, and it causes NULL pointer dereference.
This fixes it by making ufshcd_config_vreg_{h,l}pm noop when no regulators
are defined.
Signed-off-by: Akinobu Mita <mita@fixstars.com>
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to '')
| -rw-r--r-- | drivers/scsi/ufs/ufshcd.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 61bf002c7bd1..605ca60e8a10 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4268,12 +4268,18 @@ static int ufshcd_config_vreg_load(struct device *dev, struct ufs_vreg *vreg, static inline int ufshcd_config_vreg_lpm(struct ufs_hba *hba, struct ufs_vreg *vreg) { + if (!vreg) + return 0; + return ufshcd_config_vreg_load(hba->dev, vreg, UFS_VREG_LPM_LOAD_UA); } static inline int ufshcd_config_vreg_hpm(struct ufs_hba *hba, struct ufs_vreg *vreg) { + if (!vreg) + return 0; + return ufshcd_config_vreg_load(hba->dev, vreg, vreg->max_uA); } |