|author||Jeremy Sowden <email@example.com>||2019-05-15 12:14:37 +0100|
|committer||Greg Kroah-Hartman <firstname.lastname@example.org>||2019-05-20 07:40:41 +0200|
|parent||staging: kpc2000: added missing clean-up to probe_core_uio. (diff)|
staging: kpc2000: clean up after probe failure.
On error, kp2000_probe_cores just returned an error without freeing resources which had previously been allocated. Added the missing clean-up code. Updated TODO. Signed-off-by: Jeremy Sowden <email@example.com> Reviewed-by: Dan Carpenter <firstname.lastname@example.org> Signed-off-by: Greg Kroah-Hartman <email@example.com>
Diffstat (limited to 'drivers/staging/kpc2000/TODO')
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/kpc2000/TODO b/drivers/staging/kpc2000/TODO
index ed951acc829a..669fe5bf9637 100644
@@ -1,7 +1,6 @@
- the kpc_spi driver doesn't seem to let multiple transactions (to different instances of the core) happen in parallel...
- The kpc_i2c driver is a hot mess, it should probably be cleaned up a ton. It functions against current hardware though.
- pcard->card_num in kp2000_pcie_probe() is a global variable and needs atomic / locking / something better.
-- the loop in kp2000_probe_cores() that uses probe_core_uio() also probably needs error handling
- would be nice if the AIO fileops in kpc_dma could be made to work
- probably want to add a CONFIG_ option to control compilation of the AIO functions
- if the AIO fileops in kpc_dma start working, next would be making iov_count > 1 work too