diff options
| author |   Tobin C. Harding <me@tobin.cc> | 2017-03-22 11:59:53 +1100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-23 14:27:23 +0100 |
| commit | b5ca039ac17594e870a12c68ca8847700aa300dd (patch) | |
| tree | 077732d29520aa6679fc55d2aff4dddc504ef8d8 /drivers/staging/ks7010/ks_wlan_net.c | |
| parent | staging: ks7010: fix memcmp() bug (diff) | |
| download | linux-dev-b5ca039ac17594e870a12c68ca8847700aa300dd.tar.xz linux-dev-b5ca039ac17594e870a12c68ca8847700aa300dd.zip | |
staging: ks7010: add explicit check to memcmp() calls
Calls to functions memcmp() and strcmp() are more clearly readable
when the return value is explicitly checked. i.e
if (memcmp(foo, bar, size) == 0)
Modify driver to use an explicit check on the value returned by
memcmp().
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/staging/ks7010/ks_wlan_net.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index 3f9eba4065bd..c097ecd576db 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -1924,9 +1924,8 @@ static int ks_wlan_set_pmksa(struct net_device *dev, if (list_empty(&priv->pmklist.head)) { /* new list */ for (i = 0; i < PMK_LIST_MAX; i++) { pmk = &priv->pmklist.pmk[i]; - if (!memcmp - ("\x00\x00\x00\x00\x00\x00", pmk->bssid, - ETH_ALEN)) + if (memcmp("\x00\x00\x00\x00\x00\x00", + pmk->bssid, ETH_ALEN) == 0) break; /* loop */ } memcpy(pmk->bssid, pmksa->bssid.sa_data, ETH_ALEN); @@ -1938,7 +1937,7 @@ static int ks_wlan_set_pmksa(struct net_device *dev, /* search cache data */ list_for_each(ptr, &priv->pmklist.head) { pmk = list_entry(ptr, struct pmk_t, list); - if (!memcmp(pmksa->bssid.sa_data, pmk->bssid, ETH_ALEN)) { /* match address! list move to head. */ + if (memcmp(pmksa->bssid.sa_data, pmk->bssid, ETH_ALEN) == 0) { memcpy(pmk->pmkid, pmksa->pmkid, IW_PMKID_LEN); list_move(&pmk->list, &priv->pmklist.head); break; /* list_for_each */ @@ -1950,8 +1949,8 @@ static int ks_wlan_set_pmksa(struct net_device *dev, if (priv->pmklist.size < PMK_LIST_MAX) { /* new cache data */ for (i = 0; i < PMK_LIST_MAX; i++) { pmk = &priv->pmklist.pmk[i]; - if (!memcmp("\x00\x00\x00\x00\x00\x00", - pmk->bssid, ETH_ALEN)) + if (memcmp("\x00\x00\x00\x00\x00\x00", + pmk->bssid, ETH_ALEN) == 0) break; /* loop */ } memcpy(pmk->bssid, pmksa->bssid.sa_data, ETH_ALEN); @@ -1973,7 +1972,7 @@ static int ks_wlan_set_pmksa(struct net_device *dev, /* search cache data */ list_for_each(ptr, &priv->pmklist.head) { pmk = list_entry(ptr, struct pmk_t, list); - if (!memcmp(pmksa->bssid.sa_data, pmk->bssid, ETH_ALEN)) { /* match address! list del. */ + if (memcmp(pmksa->bssid.sa_data, pmk->bssid, ETH_ALEN) == 0) { eth_zero_addr(pmk->bssid); memset(pmk->pmkid, 0, IW_PMKID_LEN); list_del_init(&pmk->list); |