aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/speakup/varhandlers.c
diff options
context:
space:
mode:
authorSamuel Thibault <samuel.thibault@ens-lyon.org>2019-02-23 20:42:19 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-02-26 11:50:17 +0100
commit615cba3557f1bad6061acde2067a3edbf80d90c2 (patch)
tree5a5fc3710f18cd72e12a6ee4653a20be98b9e798 /drivers/staging/speakup/varhandlers.c
parentstaging: comedi: ni_tio: Allocate shadow regs for each counter chip (diff)
downloadlinux-dev-615cba3557f1bad6061acde2067a3edbf80d90c2.tar.xz
linux-dev-615cba3557f1bad6061acde2067a3edbf80d90c2.zip
staging: speakup: Note that simple_strtoul can't simply be replaced by kstrtoul
We often receive patches which erroneously try to use kstrtoul in these places. Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '')
-rw-r--r--drivers/staging/speakup/varhandlers.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 1b545152cc49..3c944cb8f547 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -328,6 +328,7 @@ char *spk_s2uchar(char *start, char *dest)
{
int val;
+ /* Do not replace with kstrtoul: here we need start to be updated */
val = simple_strtoul(skip_spaces(start), &start, 10);
if (*start == ',')
start++;