diff options
| author |   Stefano Stabellini <sstabellini@kernel.org> | 2018-02-28 18:05:34 -0800 |
|---|---|---|
| committer |   Juergen Gross <jgross@suse.com> | 2018-03-01 07:23:36 +0100 |
| commit | d811bcee1f7a379cad893fdee4c8db5775963b7f (patch) | |
| tree | 17b1b13bd4777b6f26d65280d765e9d34ad26e9d /drivers/xen/pvcalls-front.c | |
| parent | x86/xen: add tty0 and hvc0 as preferred consoles for dom0 (diff) | |
| download | linux-dev-d811bcee1f7a379cad893fdee4c8db5775963b7f.tar.xz linux-dev-d811bcee1f7a379cad893fdee4c8db5775963b7f.zip | |
pvcalls-front: 64-bit align flags
We are using test_and_* operations on the status and flag fields of
struct sock_mapping. However, these functions require the operand to be
64-bit aligned on arm64. Currently, only status is 64-bit aligned.
Make status and flags explicitly 64-bit aligned.
Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/xen/pvcalls-front.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index aedbee3b2838..2f11ca72a281 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -73,20 +73,25 @@ struct sock_mapping { wait_queue_head_t inflight_conn_req; } active; struct { - /* Socket status */ + /* + * Socket status, needs to be 64-bit aligned due to the + * test_and_* functions which have this requirement on arm64. + */ #define PVCALLS_STATUS_UNINITALIZED 0 #define PVCALLS_STATUS_BIND 1 #define PVCALLS_STATUS_LISTEN 2 - uint8_t status; + uint8_t status __attribute__((aligned(8))); /* * Internal state-machine flags. * Only one accept operation can be inflight for a socket. * Only one poll operation can be inflight for a given socket. + * flags needs to be 64-bit aligned due to the test_and_* + * functions which have this requirement on arm64. */ #define PVCALLS_FLAG_ACCEPT_INFLIGHT 0 #define PVCALLS_FLAG_POLL_INFLIGHT 1 #define PVCALLS_FLAG_POLL_RET 2 - uint8_t flags; + uint8_t flags __attribute__((aligned(8))); uint32_t inflight_req_id; struct sock_mapping *accept_map; wait_queue_head_t inflight_accept_req; |