diff options
| author |   David Brownell <david-b@pacbell.net> | 2007-12-04 23:45:10 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-12-05 09:21:18 -0800 |
| commit | 3f86f14c0fc9fdb0984e64209df2f47895a07151 (patch) | |
| tree | 9dd400b97efa5260c31044efd5687a4d91c04bb7 /drivers | |
| parent | SPI: use mutex not semaphore (diff) | |
| download | linux-dev-3f86f14c0fc9fdb0984e64209df2f47895a07151.tar.xz linux-dev-3f86f14c0fc9fdb0984e64209df2f47895a07151.zip | |
spi: at25 driver is for EEPROM not FLASH
Add comment to at25 driver that it's for EEPROM chips, not FLASH
chips ... the AT25 series has both types of chip, and sometimes
they're even pin-compatible. The command sets are different, as
is the treatment of erasure. (FLASH needs explicit erasure, but
with EEPROM it's implicit.) Note that all vendors seem to have
this same confusion in their *25* series SPI memory parts.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/spi/at25.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/spi/at25.c b/drivers/spi/at25.c index e007833cca59..290dbe99647a 100644 --- a/drivers/spi/at25.c +++ b/drivers/spi/at25.c @@ -21,6 +21,13 @@ #include <linux/spi/eeprom.h> +/* + * NOTE: this is an *EEPROM* driver. The vagaries of product naming + * mean that some AT25 products are EEPROMs, and others are FLASH. + * Handle FLASH chips with the drivers/mtd/devices/m25p80.c driver, + * not this one! + */ + struct at25_data { struct spi_device *spi; struct mutex lock; |