aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorCarlo Caione <carlo@endlessm.com>2017-05-30 22:39:46 +0200
committerJiri Kosina <jkosina@suse.cz>2017-06-02 14:13:22 +0200
commit715e944f8a7a1059db5d61ebf197e6f348d747e2 (patch)
tree704fc67c91e059925e3681b585290992a0527bd9 /drivers
parentHID: i2c: Call acpi_device_fix_up_power for ACPI-enumerated devices (diff)
downloadlinux-dev-715e944f8a7a1059db5d61ebf197e6f348d747e2.tar.xz
linux-dev-715e944f8a7a1059db5d61ebf197e6f348d747e2.zip
HID: asus: Stop underlying hardware on remove
We are missing a call to hid_hw_stop() on the remove hook. Among other things this is causing an Oops when (re-)starting GNOME / upowerd / ... after the module has been already rmmod-ed. Signed-off-by: Carlo Caione <carlo@endlessm.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/hid/hid-asus.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 101ab2e63d18..a6268f2f7408 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -537,6 +537,8 @@ static void asus_remove(struct hid_device *hdev)
drvdata->kbd_backlight->removed = true;
cancel_work_sync(&drvdata->kbd_backlight->work);
}
+
+ hid_hw_stop(hdev);
}
static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,