diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 13:57:50 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-09-27 10:14:14 +0200 |
| commit | 7f9e88e6ef8c971f2c638b5ff7044c59b5d0f58d (patch) | |
| tree | 7d0036be2945f2d11a20e6b860496d356c402a84 /drivers | |
| parent | enetc: Fix a signedness bug in enetc_of_get_phy() (diff) | |
| download | linux-dev-7f9e88e6ef8c971f2c638b5ff7044c59b5d0f58d.tar.xz linux-dev-7f9e88e6ef8c971f2c638b5ff7044c59b5d0f58d.zip | |
net: socionext: Fix a signedness bug in ave_probe()
The "phy_mode" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.
Fixes: 4c270b55a5af ("net: ethernet: socionext: add AVE ethernet driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/socionext/sni_ave.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c index 10d0c3e478ab..d047a53f34f2 100644 --- a/drivers/net/ethernet/socionext/sni_ave.c +++ b/drivers/net/ethernet/socionext/sni_ave.c @@ -1566,7 +1566,7 @@ static int ave_probe(struct platform_device *pdev) np = dev->of_node; phy_mode = of_get_phy_mode(np); - if (phy_mode < 0) { + if ((int)phy_mode < 0) { dev_err(dev, "phy-mode not found\n"); return -EINVAL; } |