diff options
| author |   Dmitry Bogdanov <dmitry.bogdanov@aquantia.com> | 2019-10-11 13:45:22 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-14 17:01:53 -0700 |
| commit | d08b9a0a3ebdf71b0aabe576c7dd48e57e80e0f0 (patch) | |
| tree | 692cc43ef11468ab88d6229d7405b532cdaf83d1 /drivers | |
| parent | net: aquantia: when cleaning hw cache it should be toggled (diff) | |
| download | linux-dev-d08b9a0a3ebdf71b0aabe576c7dd48e57e80e0f0.tar.xz linux-dev-d08b9a0a3ebdf71b0aabe576c7dd48e57e80e0f0.zip | |
net: aquantia: do not pass lro session with invalid tcp checksum
Individual descriptors on LRO TCP session should be checked
for CRC errors. It was discovered that HW recalculates
L4 checksums on LRO session and does not break it up on bad L4
csum.
Thus, driver should aggregate HW LRO L4 statuses from all individual
buffers of LRO session and drop packet if one of the buffers has bad
L4 checksum.
Fixes: f38f1ee8aeb2 ("net: aquantia: check rx csum for all packets in LRO session")
Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c index 3901d7994ca1..76bdbe1596d6 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c @@ -313,6 +313,7 @@ int aq_ring_rx_clean(struct aq_ring_s *self, break; buff->is_error |= buff_->is_error; + buff->is_cso_err |= buff_->is_cso_err; } while (!buff_->is_eop); @@ -320,7 +321,7 @@ int aq_ring_rx_clean(struct aq_ring_s *self, err = 0; goto err_exit; } - if (buff->is_error) { + if (buff->is_error || buff->is_cso_err) { buff_ = buff; do { next_ = buff_->next, |