aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorSony Chacko <sony.chacko@qlogic.com>2011-04-01 14:27:59 +0000
committerDavid S. Miller <davem@davemloft.net>2011-04-06 12:47:10 -0700
commitf848d6dd10e8e27d5dd61a8ab7174a7dde3a3db5 (patch)
tree3137c44def0f18cb2afb103fb5399f2c009da9b8 /drivers
parentqlcnic: Make PCI info available in all modes (diff)
downloadlinux-dev-f848d6dd10e8e27d5dd61a8ab7174a7dde3a3db5.tar.xz
linux-dev-f848d6dd10e8e27d5dd61a8ab7174a7dde3a3db5.zip
qlcnic: Memory leak fix
Fix a memory leak in error path of pci info. Signed-off-by: Sony Chacko <sony.chacko@qlogic.com> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/qlcnic/qlcnic_main.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index d230fdde28af..de6f86681a3c 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -464,8 +464,10 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter)
for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++) {
pfn = pci_info[i].id;
- if (pfn > QLCNIC_MAX_PCI_FUNC)
- return QL_STATUS_INVALID_PARAM;
+ if (pfn > QLCNIC_MAX_PCI_FUNC) {
+ ret = QL_STATUS_INVALID_PARAM;
+ goto err_eswitch;
+ }
adapter->npars[pfn].active = (u8)pci_info[i].active;
adapter->npars[pfn].type = (u8)pci_info[i].type;
adapter->npars[pfn].phy_port = (u8)pci_info[i].default_port;