diff options
| author |   David Howells <dhowells@redhat.com> | 2019-05-10 23:03:31 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2019-05-16 16:25:21 +0100 |
| commit | c7226e407b6065d3bda8bd9dc627663d2c505ea3 (patch) | |
| tree | ffdfd1eb1aa6c2096f4bc371b3347b57427665b9 /fs/afs/flock.c | |
| parent | afs: Don't invalidate callback if AFS_VNODE_DIR_VALID not set (diff) | |
| download | linux-dev-c7226e407b6065d3bda8bd9dc627663d2c505ea3.tar.xz linux-dev-c7226e407b6065d3bda8bd9dc627663d2c505ea3.zip | |
afs: Fix lock-wait/callback-break double locking
__afs_break_callback() holds vnode->lock around its call of
afs_lock_may_be_available() - which also takes that lock.
Fix this by not taking the lock in __afs_break_callback().
Also, there's no point checking the granted_locks and pending_locks queues;
it's sufficient to check lock_state, so move that check out of
afs_lock_may_be_available() into __afs_break_callback() to replace the
queue checks.
Fixes: e8d6c554126b ("AFS: implement file locking")
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/afs/flock.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/afs/flock.c b/fs/afs/flock.c index 3501ef7ddbb4..c91cd201013f 100644 --- a/fs/afs/flock.c +++ b/fs/afs/flock.c @@ -41,9 +41,6 @@ void afs_lock_may_be_available(struct afs_vnode *vnode) { _enter("{%llx:%llu}", vnode->fid.vid, vnode->fid.vnode); - if (vnode->lock_state != AFS_VNODE_LOCK_WAITING_FOR_CB) - return; - spin_lock(&vnode->lock); if (vnode->lock_state == AFS_VNODE_LOCK_WAITING_FOR_CB) afs_next_locker(vnode, 0); |