aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/ctree.c
diff options
context:
space:
mode:
authorQu Wenruo <wqu@suse.com>2019-09-10 15:40:19 +0800
committerDavid Sterba <dsterba@suse.com>2019-11-18 12:46:46 +0100
commit34ffafdba12eee3e387694edd128e954fd355e8e (patch)
tree4c13f93f4a9c0b92f626fd80fab1328620c9d51d /fs/btrfs/ctree.c
parentbtrfs: ctree: Reduce one indent level for btrfs_search_old_slot() (diff)
downloadlinux-dev-34ffafdba12eee3e387694edd128e954fd355e8e.tar.xz
linux-dev-34ffafdba12eee3e387694edd128e954fd355e8e.zip
btrfs: ctree: Remove stray comment of setting up path lock
The following comment shows up in btrfs_search_slot() with out much sense: /* * setup the path here so we can release it under lock * contention with the cow code */ if (cow) { /* code touching path->lock[] is far away from here */ } This comment hasn't been cleaned up after the relevant code has been removed. The original code is introduced in commit 65b51a009e29 ("btrfs_search_slot: reduce lock contention by cowing in two stages"): + + /* + * setup the path here so we can release it under lock + * contention with the cow code + */ + p->nodes[level] = b; + if (!p->skip_locking) + p->locks[level] = 1; + But in current code, we have different timing for modifying path lock, so just remove the comment. Reviewed-by: Nikolay Borisov <nborisov@suse.com> Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to '')
-rw-r--r--fs/btrfs/ctree.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 42ca326a0e6b..0231141de289 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -2789,10 +2789,6 @@ again:
level = btrfs_header_level(b);
- /*
- * setup the path here so we can release it under lock
- * contention with the cow code
- */
if (cow) {
bool last_level = (level == (BTRFS_MAX_LEVEL - 1));