diff options
| author |   Omar Sandoval <osandov@fb.com> | 2019-12-02 17:34:21 -0800 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2020-01-20 16:40:54 +0100 |
| commit | 169d2c875ec6461f6d18aaddbc1f30ba2b6b5a29 (patch) | |
| tree | a7ef4239a293e203882b0926dffb530ac144e5cf /fs/btrfs/extent_io.c | |
| parent | btrfs: remove unnecessary pg_offset assignments in __extent_writepage() (diff) | |
| download | linux-dev-169d2c875ec6461f6d18aaddbc1f30ba2b6b5a29.tar.xz linux-dev-169d2c875ec6461f6d18aaddbc1f30ba2b6b5a29.zip | |
btrfs: remove trivial goto label in __extent_writepage()
Since 40f765805f08 ("Btrfs: split up __extent_writepage to lower stack
usage"), done_unlocked is simply a return 0. Get rid of it.
Mid-statement block returns don seem to make the code less readable here.
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/btrfs/extent_io.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index b2d0418a4c55..9475e81dc419 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -3596,7 +3596,7 @@ static int __extent_writepage(struct page *page, struct writeback_control *wbc, if (!epd->extent_locked) { ret = writepage_delalloc(inode, page, wbc, start, &nr_written); if (ret == 1) - goto done_unlocked; + return 0; if (ret) goto done; } @@ -3604,7 +3604,7 @@ static int __extent_writepage(struct page *page, struct writeback_control *wbc, ret = __extent_writepage_io(inode, page, wbc, epd, i_size, nr_written, &nr); if (ret == 1) - goto done_unlocked; + return 0; done: if (nr == 0) { @@ -3619,9 +3619,6 @@ done: unlock_page(page); ASSERT(ret <= 0); return ret; - -done_unlocked: - return 0; } void wait_on_extent_buffer_writeback(struct extent_buffer *eb) |