aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext3/super.c
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2012-07-11 23:16:25 +0200
committerJan Kara <jack@suse.cz>2012-09-12 15:52:03 +0200
commit09e05d4805e6c524c1af74e524e5d0528bb3fef3 (patch)
tree8522776e5ad521026885806f5fb8276be0c7dc1b /fs/ext3/super.c
parentUDF: Add support for O_DIRECT (diff)
downloadlinux-dev-09e05d4805e6c524c1af74e524e5d0528bb3fef3.tar.xz
linux-dev-09e05d4805e6c524c1af74e524e5d0528bb3fef3.zip
jbd: Fix assertion failure in commit code due to lacking transaction credits
ext3 users of data=journal mode with blocksize < pagesize were occasionally hitting assertion failure in journal_commit_transaction() checking whether the transaction has at least as many credits reserved as buffers attached. The core of the problem is that when a file gets truncated, buffers that still need checkpointing or that are attached to the committing transaction are left with buffer_mapped set. When this happens to buffers beyond i_size attached to a page stradding i_size, subsequent write extending the file will see these buffers and as they are mapped (but underlying blocks were freed) things go awry from here. The assertion failure just coincidentally (and in this case luckily as we would start corrupting filesystem) triggers due to journal_head not being properly cleaned up as well. Under some rare circumstances this bug could even hit data=ordered mode users. There the assertion won't trigger and we would end up corrupting the filesystem. We fix the problem by unmapping buffers if possible (in lots of cases we just need a buffer attached to a transaction as a place holder but it must not be written out anyway). And in one case, we just have to bite the bullet and wait for transaction commit to finish. Reviewed-by: Josef Bacik <jbacik@fusionio.com> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext3/super.c')
0 files changed, 0 insertions, 0 deletions