diff options
| author |   Jan Blunck <jblunck@infradead.org> | 2010-02-24 13:25:30 +0100 |
|---|---|---|
| committer |   Arnd Bergmann <arnd@arndb.de> | 2010-10-04 21:10:37 +0200 |
| commit | 77b54a46a83232d172d55013c3af838190615260 (patch) | |
| tree | 288a399af0d549df198e3773087bf034a7281383 /fs/ext3/super.c | |
| parent | BKL: Remove BKL from ext3 fill_super() (diff) | |
| download | linux-dev-77b54a46a83232d172d55013c3af838190615260.tar.xz linux-dev-77b54a46a83232d172d55013c3af838190615260.zip | |
BKL: Remove BKL from ext3_put_super() and ext3_remount()
The BKL lock is protecting the remounting against a potential call to
ext3_put_super(). This could not happen, since this is protected by the
s_umount rw semaphore of struct super_block.
Therefore I think the BKL is protecting nothing here.
Signed-off-by: Jan Blunck <jblunck@infradead.org>
Acked-by: Jan Kara <jack@suse.cz>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to '')
| -rw-r--r-- | fs/ext3/super.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index edde63fdb9a1..2e20bd771337 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -411,9 +411,6 @@ static void ext3_put_super (struct super_block * sb) int i, err; dquot_disable(sb, -1, DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED); - - lock_kernel(); - ext3_xattr_put_super(sb); err = journal_destroy(sbi->s_journal); sbi->s_journal = NULL; @@ -462,8 +459,6 @@ static void ext3_put_super (struct super_block * sb) sb->s_fs_info = NULL; kfree(sbi->s_blockgroup_lock); kfree(sbi); - - unlock_kernel(); } static struct kmem_cache *ext3_inode_cachep; @@ -2534,8 +2529,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) int i; #endif - lock_kernel(); - /* Store the original options */ lock_super(sb); old_sb_flags = sb->s_flags; @@ -2644,7 +2637,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) kfree(old_opts.s_qf_names[i]); #endif unlock_super(sb); - unlock_kernel(); if (enable_quota) dquot_resume(sb, -1); @@ -2665,7 +2657,6 @@ restore_opts: } #endif unlock_super(sb); - unlock_kernel(); return err; } |