diff options
| author |   Baokun Li <libaokun1@huawei.com> | 2022-06-16 10:13:57 +0800 |
|---|---|---|
| committer |   Theodore Ts'o <tytso@mit.edu> | 2022-08-02 23:52:44 -0400 |
| commit | c9fd167d57133c5b748d16913c4eabc55e531c73 (patch) | |
| tree | 2973bcc918768e510d1f39c6449cf60cd90f656e /fs/ext4/inline.c | |
| parent | ext4: fix use-after-free in ext4_xattr_set_entry (diff) | |
| download | linux-dev-c9fd167d57133c5b748d16913c4eabc55e531c73.tar.xz linux-dev-c9fd167d57133c5b748d16913c4eabc55e531c73.zip | |
ext4: correct max_inline_xattr_value_size computing
If the ext4 inode does not have xattr space, 0 is returned in the
get_max_inline_xattr_value_size function. Otherwise, the function returns
a negative value when the inode does not contain EXT4_STATE_XATTR.
Cc: stable@kernel.org
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220616021358.2504451-4-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to '')
| -rw-r--r-- | fs/ext4/inline.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index 1fa36cbe09ec..a4fbe825694b 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -36,6 +36,9 @@ static int get_max_inline_xattr_value_size(struct inode *inode, struct ext4_inode *raw_inode; int free, min_offs; + if (!EXT4_INODE_HAS_XATTR_SPACE(inode)) + return 0; + min_offs = EXT4_SB(inode->i_sb)->s_inode_size - EXT4_GOOD_OLD_INODE_SIZE - EXT4_I(inode)->i_extra_isize - |