diff options
| author |   Xin Yin <yinxin.x@bytedance.com> | 2021-12-23 11:23:36 +0800 |
|---|---|---|
| committer |   Theodore Ts'o <tytso@mit.edu> | 2022-01-10 13:25:54 -0500 |
| commit | 0b5b5a62b945a141e64011b2f90ee7e46f14be98 (patch) | |
| tree | c835a07fc401c4c44530cb468f68900194914f98 /fs/ext4/inode.c | |
| parent | ext4: fix fast commit may miss tracking range for FALLOC_FL_ZERO_RANGE (diff) | |
| download | linux-dev-0b5b5a62b945a141e64011b2f90ee7e46f14be98.tar.xz linux-dev-0b5b5a62b945a141e64011b2f90ee7e46f14be98.zip | |
ext4: use ext4_ext_remove_space() for fast commit replay delete range
For now ,we use ext4_punch_hole() during fast commit replay delete range
procedure. But it will be affected by inode->i_size, which may not
correct during fast commit replay procedure. The following test will
failed.
-create & write foo (len 1000K)
-falloc FALLOC_FL_ZERO_RANGE foo (range 400K - 600K)
-create & fsync bar
-falloc FALLOC_FL_PUNCH_HOLE foo (range 300K-500K)
-fsync foo
-crash before a full commit
After the fast_commit reply procedure, the range 400K-500K will not be
removed. Because in this case, when calling ext4_punch_hole() the
inode->i_size is 0, and it just retruns with doing nothing.
Change to use ext4_ext_remove_space() instead of ext4_punch_hole()
to remove blocks of inode directly.
Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20211223032337.5198-2-yinxin.x@bytedance.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions