diff options
| author |   Steven Whitehouse <swhiteho@redhat.com> | 2007-08-27 13:54:05 +0100 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2007-10-10 08:56:00 +0100 |
| commit | 9b9107a5a8b190e6cf09bbdf893869c6a9c482cc (patch) | |
| tree | 77016dd5476f6ba72605ac0cdcbccec3ce794057 /fs/gfs2/meta_io.h | |
| parent | [GFS2] Don't mark jdata dirty in gfs2_unstuffer_page() (diff) | |
| download | linux-dev-9b9107a5a8b190e6cf09bbdf893869c6a9c482cc.tar.xz linux-dev-9b9107a5a8b190e6cf09bbdf893869c6a9c482cc.zip | |
[GFS2] Move pin/unpin into lops.c, clean up locking
gfs2_pin and gfs2_unpin are only used in lops.c, despite being
defined in meta_io.c, so this patch moves them into lops.c and
makes them static. At the same time, its possible to clean up
the locking in the buf and databuf _lo_add() functions so that
we only need to grab the spinlock once. Also we have to move
lock_buffer() around the _lo_add() functions since we can't
do that in gfs2_pin() any more since we hold the spinlock
for the duration of that function.
As a result, the code shrinks by 12 lines and we do far fewer
operations when adding buffers to the log. It also makes the
code somewhat easier to read & understand.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/gfs2/meta_io.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/gfs2/meta_io.h b/fs/gfs2/meta_io.h index 527bf19d9690..fd67f07cd60e 100644 --- a/fs/gfs2/meta_io.h +++ b/fs/gfs2/meta_io.h @@ -50,9 +50,6 @@ int gfs2_meta_wait(struct gfs2_sbd *sdp, struct buffer_head *bh); void gfs2_attach_bufdata(struct gfs2_glock *gl, struct buffer_head *bh, int meta); -void gfs2_pin(struct gfs2_sbd *sdp, struct buffer_head *bh); -void gfs2_unpin(struct gfs2_sbd *sdp, struct buffer_head *bh, - struct gfs2_ail *ai); void gfs2_meta_wipe(struct gfs2_inode *ip, u64 bstart, u32 blen); |