aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfs
diff options
context:
space:
mode:
authorSun Ke <sunke32@huawei.com>2022-08-12 09:14:40 +0800
committerTrond Myklebust <trond.myklebust@hammerspace.com>2022-08-13 13:02:13 -0400
commit2067231a9e2cbbcae0a4aca6ac36ff2dd6a7b701 (patch)
treef10ae762d95b8ba57fcc995ab4b464c1a51fcf1b /fs/nfs
parentNFS: Improve readpage/writepage tracing (diff)
downloadlinux-dev-2067231a9e2cbbcae0a4aca6ac36ff2dd6a7b701.tar.xz
linux-dev-2067231a9e2cbbcae0a4aca6ac36ff2dd6a7b701.zip
NFS: Fix missing unlock in nfs_unlink()
Add the missing unlock before goto. Fixes: 3c59366c207e ("NFS: don't unhash dentry during unlink/rename") Signed-off-by: Sun Ke <sunke32@huawei.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r--fs/nfs/dir.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index dbab3caa15ed..1b879584d4fe 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -2484,8 +2484,10 @@ int nfs_unlink(struct inode *dir, struct dentry *dentry)
*/
error = -ETXTBSY;
if (WARN_ON(dentry->d_flags & DCACHE_NFSFS_RENAMED) ||
- WARN_ON(dentry->d_fsdata == NFS_FSDATA_BLOCKED))
+ WARN_ON(dentry->d_fsdata == NFS_FSDATA_BLOCKED)) {
+ spin_unlock(&dentry->d_lock);
goto out;
+ }
if (dentry->d_fsdata)
/* old devname */
kfree(dentry->d_fsdata);