diff options
| author |   Jan Kara <jack@suse.cz> | 2014-12-10 15:41:42 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2014-12-10 17:41:03 -0800 |
| commit | 4a635a113bfe1eaa184410d6b6065cd8eee13607 (patch) | |
| tree | cacaeb92ded0b14a914c66150913302c0e712de1 /fs/ocfs2/inode.c | |
| parent | ocfs2: Fix xattr check in ocfs2_get_xattr_nolock() (diff) | |
| download | linux-dev-4a635a113bfe1eaa184410d6b6065cd8eee13607.tar.xz linux-dev-4a635a113bfe1eaa184410d6b6065cd8eee13607.zip | |
ocfs2: remove bogus test from ocfs2_read_locked_inode()
'args' are always set for ocfs2_read_locked_inode() and brelse() checks
whether bh is NULL. So the test (args && bh) is unnecessary (plus the
args part is really confusing anyway). Remove it.
Coverity id: 1128856.
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | fs/ocfs2/inode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 437de7f768c6..c8b25de9efbb 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -540,8 +540,7 @@ bail: if (status < 0) make_bad_inode(inode); - if (args && bh) - brelse(bh); + brelse(bh); return status; } |