diff options
| author |   Jia-Ju Bai <baijiaju1990@gmail.com> | 2019-10-06 17:57:54 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2019-10-07 15:47:19 -0700 |
| commit | 583fee3e12df0e6f1f66f063b989d8e7fed0e65a (patch) | |
| tree | 931c6c1c8858cb2a91a153b6aceb3fec6088d84f /fs/ocfs2/ioctl.c | |
| parent | fs: ocfs2: fix possible null-pointer dereferences in ocfs2_xa_prepare_entry() (diff) | |
| download | linux-dev-583fee3e12df0e6f1f66f063b989d8e7fed0e65a.tar.xz linux-dev-583fee3e12df0e6f1f66f063b989d8e7fed0e65a.zip | |
fs: ocfs2: fix a possible null-pointer dereference in ocfs2_write_end_nolock()
In ocfs2_write_end_nolock(), there are an if statement on lines 1976,
2047 and 2058, to check whether handle is NULL:
if (handle)
When handle is NULL, it is used on line 2045:
ocfs2_update_inode_fsync_trans(handle, inode, 1);
oi->i_sync_tid = handle->h_transaction->t_tid;
Thus, a possible null-pointer dereference may occur.
To fix this bug, handle is checked before calling
ocfs2_update_inode_fsync_trans().
This bug is found by a static analysis tool STCheck written by us.
Link: http://lkml.kernel.org/r/20190726033705.32307-1-baijiaju1990@gmail.com
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Gang He <ghe@suse.com>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions