diff options
| author |   Darrick J. Wong <darrick.wong@oracle.com> | 2018-10-30 10:42:24 +1100 |
|---|---|---|
| committer |   Dave Chinner <david@fromorbit.com> | 2018-10-30 10:42:24 +1100 |
| commit | 8c5c836bd6c3b9f9fc1c5a210d630b8c42f4f7df (patch) | |
| tree | b30d576876330782bc620907b9693f5b20ef4ea7 /fs/read_write.c | |
| parent | vfs: hide file range comparison function (diff) | |
| download | linux-dev-8c5c836bd6c3b9f9fc1c5a210d630b8c42f4f7df.tar.xz linux-dev-8c5c836bd6c3b9f9fc1c5a210d630b8c42f4f7df.zip | |
vfs: clean up generic_remap_file_range_prep return value
Since the remap prep function can update the length of the remap
request, we can change this function to return the usual return status
instead of the odd behavior it has now.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/read_write.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/read_write.c b/fs/read_write.c index e4d295d0d236..6b40a43edf18 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -1848,8 +1848,8 @@ out_error: * sense, and then flush all dirty data. Caller must ensure that the * inodes have been locked against any other modifications. * - * Returns: 0 for "nothing to clone", 1 for "something to clone", or - * the usual negative error code. + * If there's an error, then the usual negative error code is returned. + * Otherwise returns 0 with *len set to the request length. */ int generic_remap_file_range_prep(struct file *file_in, loff_t pos_in, struct file *file_out, loff_t pos_out, @@ -1945,7 +1945,7 @@ int generic_remap_file_range_prep(struct file *file_in, loff_t pos_in, return ret; } - return 1; + return 0; } EXPORT_SYMBOL(generic_remap_file_range_prep); |