aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/libxfs/xfs_da_format.h
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2020-01-07 15:25:39 -0800
committerDarrick J. Wong <darrick.wong@oracle.com>2020-01-09 10:55:18 -0800
commit780d29057781d986cd87dbbe232cd02876ad430f (patch)
treed4e9b2b48e7679baf585ceaccf0d46c8d172bf69 /fs/xfs/libxfs/xfs_da_format.h
parentxfs: also remove cached ACLs when removing the underlying attr (diff)
downloadlinux-dev-780d29057781d986cd87dbbe232cd02876ad430f.tar.xz
linux-dev-780d29057781d986cd87dbbe232cd02876ad430f.zip
xfs: fix misuse of the XFS_ATTR_INCOMPLETE flag
XFS_ATTR_INCOMPLETE is a flag in the on-disk attribute format, and thus in a different namespace as the ATTR_* flags in xfs_da_args.flags. Switch to using a XFS_DA_OP_INCOMPLETE flag in op_flags instead. Without this users might be able to inject this flag into operations using the attr by handle ioctl. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to '')
-rw-r--r--fs/xfs/libxfs/xfs_da_format.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/xfs/libxfs/xfs_da_format.h b/fs/xfs/libxfs/xfs_da_format.h
index 3dee33043e09..05615d1f4113 100644
--- a/fs/xfs/libxfs/xfs_da_format.h
+++ b/fs/xfs/libxfs/xfs_da_format.h
@@ -683,8 +683,6 @@ struct xfs_attr3_leafblock {
/*
* Flags used in the leaf_entry[i].flags field.
- * NOTE: the INCOMPLETE bit must not collide with the flags bits specified
- * on the system call, they are "or"ed together for various operations.
*/
#define XFS_ATTR_LOCAL_BIT 0 /* attr is stored locally */
#define XFS_ATTR_ROOT_BIT 1 /* limit access to trusted attrs */